Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Binary downloader discards custom binary name for archive source #68

Open
adityathebe opened this issue Apr 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@adityathebe
Copy link
Member

adityathebe commented Apr 21, 2023

When a custom binary name is provided and the source is an archive file, the custom binary name is dicarded.

https://github.com/flanksource/commons/blob/master/deps/deps.go#L354

Example:


"trivy": {
		Version:    "0.40.0", // without the "v" prefix
		Linux:      "https://github.com/aquasecurity/trivy/releases/download/v{{.version}}/trivy_{{.version}}_Linux-64bit.tar.gz",
		Windows:    "https://github.com/aquasecurity/trivy/releases/download/v{{.version}}/trivy_{{.version}}_windows-64bit.zip",
		Macosx:     "https://github.com/aquasecurity/trivy/releases/download/v{{.version}}/trivy_{{.version}}_macOS-64bit.tar.gz",
		BinaryName: "trivy-{{.version}}",
	},
Behavior Outcome
Expected Download as trivy-0.40.0
Current Download as trivy
@adityathebe adityathebe added the bug Something isn't working label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant