Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle new pages + fix empty match/team key #22

Merged
merged 17 commits into from
Dec 10, 2024
Merged

Conversation

awwpotato
Copy link
Contributor

  • Switch to brand colors for tele and auto
  • Restyle postmatch
  • Fix timeline animation (plz test on safari)
  • Restyle homepage buttons to closer match other buttons
  • Check that match/team key aren't empty on manual scouting
  • Restyle leave queue button

@awwpotato awwpotato marked this pull request as draft December 10, 2024 02:16
@awwpotato awwpotato marked this pull request as ready for review December 10, 2024 02:34
Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naur, I liked my big oval buttons (jk).
There's an issue where the dropdown menu is super small on arc
Screenshot 2024-12-09 at 8 31 05 PM
Also, could we get some more padding on the postmatch page, it looks kinda cramped.

Unrelated (this is my fault), but could you add a back button in the manual scout menu
Otherwise, great work

@awwpotato
Copy link
Contributor Author

awwpotato commented Dec 10, 2024

There's an issue where the dropdown menu is super small on arc Screenshot 2024-12-09 at 8 31 05 PM

This seems like a arc skill issue, can you test it in chrome and safari. Also test if this html by itself looks correct on arc plz:

<!doctype html>
<body>
  <select name="color">
    <option selected value="">Select a color</option>
    <option value="blue">Blue</option>
    <option value="red">Red</option>
  </select>
</body>

@awwpotato
Copy link
Contributor Author

but could you add a back button in the manual scout menu

Can't the user just go back to previous page using their web browser controls

@azaleacolburn
Copy link
Member

but could you add a back button in the manual scout menu

Can't the user just go back to previous page using their web browser controls

They can, they shouldn't have to though

Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@azaleacolburn azaleacolburn merged commit 1ee1ac7 into main Dec 10, 2024
@azaleacolburn azaleacolburn deleted the finnegan/style branch December 10, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants