Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the encoder code #2

Open
ShengYun-Peng opened this issue Feb 15, 2023 · 0 comments
Open

Simplify the encoder code #2

ShengYun-Peng opened this issue Feb 15, 2023 · 0 comments

Comments

@ShengYun-Peng
Copy link

ShengYun-Peng commented Feb 15, 2023 •
edited
Loading

Thanks for the clean implementation! I guess replacing the ModuleList with Sequential has the same effect, but you can remove the for loop in the following forward function.

transformer-from-scratch/src/encoder.py

Line 43 in 86076d2

self.layers = nn.ModuleList(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShengYun-Peng