Get a package last modifier based on the package name instead of the package ID to avoid a ckan.logic.NotFound exception

[ntwalibas]

Description

Running pipelines in who-afro-dags resulted in certain packages not being found by their IDs even though they clearly exist.
This PR changes the way we get a package last activity where we rely on the package name instead of the package ID which fixes the afore mentioned issue.

Testing

This PR was tested manually instead of making an automated test as I still do not know how to reliably reproduce the issue
that resulted in this work.

Checklist

• The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
• I have developed these changes in discussion with the appropriate project manager.
• My code follows the general Fjelltopp documentation (see Confluence).
• I have made corresponding changes to the Fjelltopp documentation (see Confluence).
• I have rebased this branch with master.
• New dependency changes have been committed.
• I have added automated tests that prove my fix is effective or that my feature works.
• New and existing tests pass locally with my changes.
• My changes generate no new warnings.
• I have performed a self-review of my own code.
• I have assigned at least one reviewer.
• I have assigned at least one label to this PR: "patch", "minor", "major".

[ChasNelson1990]

Why does get_last_modifier break with id but apparently get_package_stats is fine?

[ntwalibas]

@ChasNelson1990 said:

Why does get_last_modifier break with id but apparently get_package_stats is fine?

On one hand:
The Google analytics helper get_package_stats returns 0 if no package with the given ID could be found, which is the case for the problematic packages. Then once a package is added to the package table, a corresponding entry is created in the activity table. Therefore if no entry can be found in the activity table given the package ID (object_id column in the DB), an exception is raised when the package_activity_list action is invoked (which is the function called by get_last_modifier).

Also, the action package_activity_list allows you to find packages either by their name or by their ID, get_package_stats only relies on the ID.

On the other hand:
get_package_stats will display the wrong results once Google analytics has captured data about the package because there will be an inconsistency between the package_id stored in the package_stats table and the actual package ID to be found in the package table.

Good observation! It seems I got so much tunnel vision, I didn't consider the ramifications of using the package id in certain places and the package name in other places.