From af0f66c1c1b4359d4d54f537820c33b46f0af057 Mon Sep 17 00:00:00 2001 From: Fixstars-momoko Date: Wed, 23 Oct 2024 14:20:41 -0700 Subject: [PATCH 1/2] confirmed to work on Windows --- python/ionpy/native.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ionpy/native.py b/python/ionpy/native.py index 944a9192..756d222f 100644 --- a/python/ionpy/native.py +++ b/python/ionpy/native.py @@ -7,7 +7,7 @@ if platform.system() == 'Windows': ion_core_module = os.path.join(pre_built_path, 'windows/ion-core.dll') ion_bb_module = os.path.join(pre_built_path, 'windows/ion-bb.dll') - os.add_dll_directory(os.path.join(pre_built_path, 'windows')) + os.environ["PATH"] += ';{}'.format(os.path.join(pre_built_path, 'windows')) elif platform.system() == 'Darwin': ion_core_module = os.path.join(pre_built_path, 'macos/libion-core.dylib') ion_bb_module = os.path.join(pre_built_path, 'macos/libion-bb.dylib') From 1628b557045bf48bff02f485fce5abf99d02b850 Mon Sep 17 00:00:00 2001 From: fixstars_xinyu <143661893+xinyuli1204@users.noreply.github.com> Date: Thu, 24 Oct 2024 11:33:07 -0700 Subject: [PATCH 2/2] add line --- python/ionpy/native.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/ionpy/native.py b/python/ionpy/native.py index 756d222f..4110a26f 100644 --- a/python/ionpy/native.py +++ b/python/ionpy/native.py @@ -7,7 +7,8 @@ if platform.system() == 'Windows': ion_core_module = os.path.join(pre_built_path, 'windows/ion-core.dll') ion_bb_module = os.path.join(pre_built_path, 'windows/ion-bb.dll') - os.environ["PATH"] += ';{}'.format(os.path.join(pre_built_path, 'windows')) + os.environ["PATH"] = '{};'.format(os.path.join(pre_built_path, 'windows')) + os.environ["PATH"] + os.add_dll_directory(os.path.join(pre_built_path, 'windows')) elif platform.system() == 'Darwin': ion_core_module = os.path.join(pre_built_path, 'macos/libion-core.dylib') ion_bb_module = os.path.join(pre_built_path, 'macos/libion-bb.dylib')