Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CuPy base version #33

Open
LWisteria opened this issue Jul 11, 2018 · 4 comments
Open

Update CuPy base version #33

LWisteria opened this issue Jul 11, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@LWisteria
Copy link
Member

Currently based on v2.1.0.

We plan to update the version to v4.x or v5.x or more.

@ghost
Copy link

ghost commented Feb 21, 2020

Summaries of difference between (CuPy) versions:
https://docs-cupy.chainer.org/en/stable/upgrade.html

@LWisteria
Copy link
Member Author

I tried to upgrade the base version to estimate how difficult it is.

The key points are

  • Many conflicts are caused by renaming cupy to clpy
  • Even if there are no conflicts, the new commits on CuPy may include "cupy" keywords. They must be checked carefully (CI would tell us)
  • _version.py causes conflict every time... why?

@LWisteria
Copy link
Member Author

Note that the above experimental branches would not work well, I've never checked to build and run.

@LWisteria
Copy link
Member Author

The easiness shown above is from my commits made for the first time as ClPy.

In anticipation of the base version update, I firstly renamed files by git mv (f5ff2ee, 58aa4ed, and 664ccee) before overwriting ClPy changes (dec25c3) to follow later changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant