Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update Product and Inventory models following support of the GraphQL API update #93

Open
1 of 4 tasks
fivetran-joemarkiewicz opened this issue Nov 25, 2024 · 0 comments · May be fixed by #94
Open
1 of 4 tasks
Labels
error:forced good first issue Good for newcomers type:bug Something is broken or incorrect

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

fivetran-joemarkiewicz commented Nov 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

The following fields have been deprecated from the relevant tables in this data model:

  • PRODUCT_VARIANT

    • fulfillment_service
    • grams
    • inventory_management
    • inventory_quantity_management
    • inventory_quantity_adjustment
    • old_inventory_quantity
    • presentment_prices
    • requires_shipping
    • weight
    • weight_unit
    • option_*
  • PRODUCT_IMAGE

    • is_default
    • position
    • alt
    • created_at
    • updated_at
    • src
    • variant_ids
  • INVENTORY_ITEM

    • cost
  • INVENTORY_LEVEL

    • available

In addition to the deprecation of the above fields, we should replace what we can with the newly added fields for these same tables:

Please note, the below fields is a full list of added fields. I don't imagine we will be adding all of these fields, but wanted to make sure all were taken into consideration.

  • PRODUCT_VARIANT

    • available_for_sale
    • display_name
    • legacy_resource_id
    • requires_components
    • sellable_online_quantity
  • PRODUCT_IMAGE

    • media_id
    • alt_text
    • status
    • url
  • PRODUCT_OPTION

    • linked_metafield_key
    • linked_metafield_namespace
  • INVENTORY_ITEM

    • duplicate_sku_count
    • harmonized_system_code
    • inventory_history_url
    • legacy_resource_id
    • measurement_id
    • measurement_weight_value
    • measurement_weight_unit
    • tracked_editable_locked
    • tracked_editable_reason
    • unit_cost
  • INVENTORY_LEVEL

    • id
    • can_deactivate
    • created_at
    • deactivation_alert

Relevant error log or model output

This will not result in a failed data model run, but will result in null records. We need to remove and update these fields to reflect the current connector state.

Expected behavior

The data model is up to date with the most recent version of the connector

Possible solution

Update the relevant upstream source tables within the dbt_shopify_source dbt package by removing these deprecated fields and adding the new fields where relevant.

Additionally, we will need to consider any downstream implications within this dbt_shopify transformation package as well since most of these source tables are used in the downstream end models.

dbt Project configurations

Default

Package versions

Latest

What database are you using dbt with?

postgres, redshift, snowflake, bigquery, databricks

How are you running this dbt package?

Fivetran Quickstart Data Model, Fivetran Transformations, dbt Core™, dbt Cloud™

dbt Version

Latest

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance.
  • No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error:forced good first issue Good for newcomers type:bug Something is broken or incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant