Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont transform db name #6

Open
jchris opened this issue Oct 31, 2024 · 1 comment
Open

dont transform db name #6

jchris opened this issue Oct 31, 2024 · 1 comment
Assignees

Comments

@jchris
Copy link
Collaborator

jchris commented Oct 31, 2024

I think if there is a place we need to be safe with db name characters it shoudnt be here. Principle of least surprise says we should pass through at this layer

const sanitizedRemoteName = remoteName

@necrodome
Copy link
Contributor

I agree but by default indexeddb gateway does this cleaning,
https://github.com/fireproof-storage/fireproof/blob/e485c4c2917ab58bb399b0cb549c98bbd2ffaecc/src/runtime/gateways/indexdb/gateway.ts#L64

I just added this to match the current behaviour so we can match it on cloud connect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants