Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use wrapper or limiter options with physics yet #419

Closed
tommbendall opened this issue Aug 7, 2023 · 1 comment
Closed

Can't use wrapper or limiter options with physics yet #419

tommbendall opened this issue Aug 7, 2023 · 1 comment

Comments

@tommbendall
Copy link
Contributor

Trying to use a wrapper or limiter option with a physics scheme will likely not work.

The evaluate method for the physics scheme generally requires an input X which is in the whole mixed function space.

However wrapper/limiter options only work with a time discretisation that is evolving a single prognostic variable.

For instance to use the recovered wrapper with a physics scheme, we'd need to be able to specify the recovery options for all of the variables involved. Probably this means enhancing the wrappers.

@tommbendall
Copy link
Contributor Author

Thanks to @ta440, this has now been addressed through #471 and #459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant