Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify dictionary to function on cellnames #3900

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Modify dictionary to function on cellnames #3900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions firedrake/mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@
}


_supported_embedded_cell_types_and_gdims = [(ufl.Cell('interval'), 2),
(ufl.Cell('triangle'), 3),
(ufl.Cell("quadrilateral"), 3),
(ufl.TensorProductCell(ufl.Cell('interval'), ufl.Cell('interval')), 3)]
_supported_embedded_cell_types_and_gdims = [('interval', 2),
('triangle', 3),
("quadrilateral", 3),
("interval * interval", 3)]


unmarked = -1
Expand Down Expand Up @@ -2765,7 +2765,7 @@ def init_cell_orientations(self, expr):
import firedrake.function as function
import firedrake.functionspace as functionspace

if (self.ufl_cell(), self.geometric_dimension()) not in _supported_embedded_cell_types_and_gdims:
if (self.ufl_cell().cellname(), self.geometric_dimension()) not in _supported_embedded_cell_types_and_gdims:
raise NotImplementedError('Only implemented for intervals embedded in 2d and triangles and quadrilaterals embedded in 3d')

if hasattr(self, '_cell_orientations'):
Expand Down