Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tackle many warnings #3898

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Tackle many warnings #3898

merged 12 commits into from
Dec 5, 2024

Conversation

connorjward
Copy link
Contributor

@connorjward connorjward commented Nov 28, 2024 •
edited
Loading

TODOs

  • Use actual upstream loopy
  • Check that this isn't a major performance regression (!?) (might just be overloaded runners)

Closes #3871

(Isn't it nice that I don't need a PyOP2 PR!)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8131 ran7345 passed786 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8125 ran6540 passed1585 skipped0 failed

@connorjward connorjward mentioned this pull request Nov 29, 2024
Merged
@connorjward connorjward mentioned this pull request Dec 3, 2024
Merged
@connorjward connorjward marked this pull request as ready for review December 4, 2024 13:35
JHopeCollins
JHopeCollins reviewed Dec 4, 2024
View reviewed changes
pyop2/codegen/rep2loopy.py Show resolved Hide resolved
pyop2/codegen/rep2loopy.py Show resolved Hide resolved
pyop2/codegen/rep2loopy.py Outdated Show resolved Hide resolved
pyop2/codegen/rep2loopy.py Outdated Show resolved Hide resolved
JHopeCollins
JHopeCollins previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@JHopeCollins JHopeCollins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the workflow branches are removed.
Thanks @connorjward!

@connorjward connorjward merged commit 57217cf into master Dec 5, 2024
14 checks passed
@connorjward connorjward deleted the connorjward/pyop2-fixes branch December 5, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer inducer left review comments

@JHopeCollins JHopeCollins JHopeCollins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Cofunction += Cofunction leads to DeprecationWarnings
3 participants
@connorjward @inducer @JHopeCollins