Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: equality comparison for semantic version when number of segments = max allowed segments #2794

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: equality comparison for semantic version when number of segments = max allowed segments #2794

wants to merge 4 commits into from
+11 −4

Conversation

Namyalg
Copy link

@Namyalg Namyalg commented Dec 2, 2024 •
edited
Loading

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Testing

  • Make sure all existing tests in the repository pass after your change [Verified all existing tests pass]
  • If you fixed a bug or added a feature, add a new test to cover your code [Unit tests added]

Fixes #2793

@Namyalg Namyalg requested a review from kjelko December 2, 2024 09:56
@Namyalg Namyalg changed the title fix: equality comparison for semantic version comparison when number of segments = max allowed segments fix: equality comparison for semantic version when number of segments = max allowed segments Dec 2, 2024
kjelko
kjelko approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@kjelko kjelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjelko kjelko kjelko approved these changes

Assignees

@lahirumaramba lahirumaramba

@kjelko kjelko

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Namyalg @kjelko @lahirumaramba