Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why isn't the response of FunctionsApiClient.enqueue returned? #2791

Open
seaders opened this issue Nov 27, 2024 · 1 comment
Open

Why isn't the response of FunctionsApiClient.enqueue returned? #2791

seaders opened this issue Nov 27, 2024 · 1 comment

Comments

@seaders
Copy link

seaders commented Nov 27, 2024

Here:

https://github.com/firebase/firebase-admin-node/blame/83585498d9bd48b9ba715a882a3b9c951ca8422d/src/functions/functions-api-client-internal.ts#L162

      await this.httpClient.send(request)

Or better yet, actually check it, type it, and return it, like the google-cloud library

https://cloud.google.com/nodejs/docs/reference/tasks/latest/tasks/v2.cloudtasksclient#_google_cloud_tasks_v2_CloudTasksClient_createTask_member_1_

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/0469e1fbf20906aaef01e17b0274c79a0725b9a4/cloud-tasks/snippets/createTask.js#L77

The feat that included this option last year seemed to mention this too. Obviously that's not yet done, and is probably a load of work, so, for the moment, it'd be great if just the response of that is returned, and we can work with that.

Reason I need this is to be able to refer to a created task, to be able to delete it later (functionality I'd also love was added here) - I'd prefer to be able to edit it, specifically the scheduleTime, but that functionality doesn't seem to be available from cloud tasks.

I'm happy to submit a PR returning the response, but wanted to open this issue first, as adding that as a PR would likely get rejected out of hand.

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants