Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mill build warnings about deprecated usages. #274

Open
DamianReeves opened this issue Jul 20, 2023 · 1 comment
Open

Fix mill build warnings about deprecated usages. #274

DamianReeves opened this issue Jul 20, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@DamianReeves
Copy link
Member

Feature Request

Description of Problem:

Since upgrading to mill 0.11.x some used types are deprecated, address these deprecations.

[#0] [warn]     Jvm.runLocal("mdoc.Main", cp, dirParams)
[#0] [warn]     ^
[#0] [warn] /home/runner/work/morphir-scala/morphir-scala/project/modules/docs.sc:48:9: value Jvm in package modules is deprecated (since Mill 0.11.0-M9): use mill.util.Jvm
[#0] [warn]         Jvm.runLocal("mdoc.Main", cp, dirParams ++ Seq("--watch"))
[#0] [warn]         ^
[#0] [warn] /home/runner/work/morphir-scala/morphir-scala/project/modules/docs.sc:56:26: type Sources in package define is deprecated (since Mill after 0.11.0-M8): Use mill.define.Target instead.
[#0] [warn]   def docusaurusSources: Sources
[#0] [warn]                          ^
[#0] [warn] /home/runner/work/morphir-scala/morphir-scala/project/modules/docs.sc:57:22: type Sources in package define is deprecated (since Mill after 0.11.0-M8): Use mill.define.Target instead.
[#0] [warn]   def compiledMdocs: Sources
[#0] [warn]                      ^
[#0] [warn] /home/runner/work/morphir-scala/morphir-scala/project/modules/docs.sc:77:[19](https://github.com/finos/morphir-scala/actions/runs/5615735487/job/15216636429?pr=265#step:5:20): value Jvm in package modules is deprecated (since Mill 0.11.0-M9): use mill.util.Jvm
[#0] [warn]     val process = Jvm.spawnSubprocess(
[#0] [warn]                   ^
[#0] [warn] /home/runner/work/morphir-scala/morphir-scala/project/modules/docs.sc:153:14: value Jvm in package modules is deprecated (since Mill 0.11.0-M9): use mill.util.Jvm
[#0] [warn]     val p2 = Jvm.spawnSubprocess(
[#0] [warn]              ^
[#0] [warn] /home/runner/work/morphir-scala/morphir-scala/project/modules/docs.sc:169:5: value Jvm in package modules is deprecated (since Mill 0.11.0-M9): use mill.util.Jvm
[#0] [warn]     Jvm.runSubprocess(
@DamianReeves DamianReeves added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 20, 2023
@haesu
Copy link
Contributor

haesu commented Jul 26, 2023

Hi Damian. I made PR for this. Could you review it?
#287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants