From 6552749add661033b222c248900a30d044b08c48 Mon Sep 17 00:00:00 2001 From: Aaron Reed Date: Fri, 2 Feb 2024 13:09:25 -0500 Subject: [PATCH 1/6] finos/a11y-theme-builder#742 --- .github/workflows/publish-docker.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/publish-docker.yml b/.github/workflows/publish-docker.yml index 16c32a63..2defe36e 100644 --- a/.github/workflows/publish-docker.yml +++ b/.github/workflows/publish-docker.yml @@ -6,6 +6,7 @@ on: branches: - 'main' - 'dev' + - 'disable-docker-scan' paths: - 'code/src/**' - 'code/package.json' @@ -22,11 +23,11 @@ jobs: - name: Build run: docker build -f Dockerfile -t user/app:latest . working-directory: code - - name: Scan for vulnerabilities - uses: crazy-max/ghaction-container-scan@dfa7e54dc32045120f06d0bc8d7724860f5db0ad - with: - image: user/app:latest - severity_threshold: HIGH + #- name: Scan for vulnerabilities + # uses: crazy-max/ghaction-container-scan@dfa7e54dc32045120f06d0bc8d7724860f5db0ad + # with: + # image: user/app:latest + # severity_threshold: HIGH push-to-registry: name: Push Docker image to Docker Hub needs: docker-scan From 11761aacd720947fcf2f00315aa2a0de254cf31d Mon Sep 17 00:00:00 2001 From: Aaron Reed Date: Fri, 2 Feb 2024 13:38:59 -0500 Subject: [PATCH 2/6] finos/a11y-theme-builder#742: testing with latest github actions, forcing push to Docker to test that is still working --- .github/workflows/publish-docker.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/publish-docker.yml b/.github/workflows/publish-docker.yml index 2defe36e..a4230962 100644 --- a/.github/workflows/publish-docker.yml +++ b/.github/workflows/publish-docker.yml @@ -18,8 +18,8 @@ jobs: name: ${{ github.event.repository.name }}-docker-scan runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: docker-practice/actions-setup-docker@321477a1e481dd60b05f9b489cf4b9be467aa15c + - uses: actions/checkout@v4 + - uses: docker-practice/actions-setup-docker@v1 - name: Build run: docker build -f Dockerfile -t user/app:latest . working-directory: code @@ -34,22 +34,22 @@ jobs: runs-on: ubuntu-latest # save forks from having issue trying to publish to Docker # without the correct credentials - if: github.repository_owner == 'finos' + #if: github.repository_owner == 'finos' outputs: digest: ${{ steps.build_publish.outputs.digest }} steps: - name: Check out the repo - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Log in to Docker Hub - uses: docker/login-action@v2.1.0 + uses: docker/login-action@v3.0.0 with: username: finos password: ${{ secrets.DOCKER_PASSWORD }} - name: Extract metadata (tags, labels) for Docker id: meta - uses: docker/metadata-action@v4.1.1 + uses: docker/metadata-action@v5.5.1 with: images: finos/a11y-theme-builder tags: | @@ -57,7 +57,7 @@ jobs: type=sha - name: Build and push Docker image id: build_publish - uses: docker/build-push-action@v3.2.0 + uses: docker/build-push-action@v5.1.0 with: context: code push: true From b18e2bb0a58d4e9425a89dc82eea183553f053b0 Mon Sep 17 00:00:00 2001 From: Aaron Reed Date: Fri, 2 Feb 2024 13:48:39 -0500 Subject: [PATCH 3/6] finos/a11y-theme-builder#742: latest actions-setup-docker has issues, backing to specific version --- .github/workflows/publish-docker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-docker.yml b/.github/workflows/publish-docker.yml index a4230962..ddf0a0da 100644 --- a/.github/workflows/publish-docker.yml +++ b/.github/workflows/publish-docker.yml @@ -19,7 +19,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: docker-practice/actions-setup-docker@v1 + - uses: docker-practice/actions-setup-docker@v1.0.11 - name: Build run: docker build -f Dockerfile -t user/app:latest . working-directory: code From c21f6fad303f9ba1b660f364d65c4d85b93b6dd2 Mon Sep 17 00:00:00 2001 From: Aaron Reed Date: Fri, 2 Feb 2024 13:51:35 -0500 Subject: [PATCH 4/6] finos/a11y-theme-builder#742: latest actions-setup-docker has issues, backing to specific version --- .github/workflows/publish-docker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-docker.yml b/.github/workflows/publish-docker.yml index ddf0a0da..ee5d0ce8 100644 --- a/.github/workflows/publish-docker.yml +++ b/.github/workflows/publish-docker.yml @@ -19,7 +19,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: docker-practice/actions-setup-docker@v1.0.11 + - uses: docker-practice/actions-setup-docker@1.0.9 - name: Build run: docker build -f Dockerfile -t user/app:latest . working-directory: code From 702f8cc7a0e5d7016462610668c8f507cad6c9b7 Mon Sep 17 00:00:00 2001 From: Aaron Reed Date: Fri, 2 Feb 2024 14:33:46 -0500 Subject: [PATCH 5/6] finos/a11y-theme-builder#742: latest actions-setup-docker release has issues, reverting back to previous version that worked which is actually later than latest release version --- .github/workflows/publish-docker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-docker.yml b/.github/workflows/publish-docker.yml index ee5d0ce8..d48df702 100644 --- a/.github/workflows/publish-docker.yml +++ b/.github/workflows/publish-docker.yml @@ -19,7 +19,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: docker-practice/actions-setup-docker@1.0.9 + - uses: docker-practice/actions-setup-docker@321477a1e481dd60b05f9b489cf4b9be467aa15c - name: Build run: docker build -f Dockerfile -t user/app:latest . working-directory: code From d6a29f665b1345b0d7869889a91f85b1c591439f Mon Sep 17 00:00:00 2001 From: Aaron Reed Date: Fri, 2 Feb 2024 14:42:42 -0500 Subject: [PATCH 6/6] finos/a11y-theme-builder#742: removing changes that I had added for testing purposes --- .github/workflows/publish-docker.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/publish-docker.yml b/.github/workflows/publish-docker.yml index d48df702..ee5d4d4f 100644 --- a/.github/workflows/publish-docker.yml +++ b/.github/workflows/publish-docker.yml @@ -6,7 +6,6 @@ on: branches: - 'main' - 'dev' - - 'disable-docker-scan' paths: - 'code/src/**' - 'code/package.json' @@ -34,7 +33,7 @@ jobs: runs-on: ubuntu-latest # save forks from having issue trying to publish to Docker # without the correct credentials - #if: github.repository_owner == 'finos' + if: github.repository_owner == 'finos' outputs: digest: ${{ steps.build_publish.outputs.digest }} steps: