Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class VpnResultMethods is missing osMismatch #97

Closed
manuel-watchenterprise opened this issue Jul 16, 2024 · 3 comments · Fixed by #102
Closed

Class VpnResultMethods is missing osMismatch #97

manuel-watchenterprise opened this issue Jul 16, 2024 · 3 comments · Fixed by #102
Assignees

Comments

@manuel-watchenterprise
Copy link

The VpnResultMethods class does not include / handle osMismatch data which, however, exists in API response. This way, the information is lost and is not accessible as the class stores in its container only those properties that are known.

Original JSON response:

{
  "vpn": {
    "data": {
      "result": false,
      "originTimezone": "Europe/Budapest",
      "originCountry": "unknown",
      "methods": {
        "timezoneMismatch": false,
        "publicVPN": false,
        "auxiliaryMobile": false,
        "osMismatch": false
      }
    }
  }
}
@makma
Copy link
Member

makma commented Jul 16, 2024

Hello @manuel-watchenterprise,
Yes, you are right, the SDK has not been upgraded, yet. We are working on it right now.

ccing @Orkuncakilkaya as an owner of this initiative

@Orkuncakilkaya
Copy link
Contributor

Hey @manuel-watchenterprise 👋
This will be released in the following major Fingerprint Pro Server API PHP SDK release.

@Orkuncakilkaya Orkuncakilkaya self-assigned this Jul 17, 2024
@Orkuncakilkaya Orkuncakilkaya linked a pull request Aug 27, 2024 that will close this issue
@Orkuncakilkaya
Copy link
Contributor

With version 5.0.0, you can get VPN signals like this

/** @var \Fingerprint\ServerAPI\Model\EventResponse $result */
list($result, $response) = $client->getEvent($request_id);

$vpnResult = $result->getProducts()->getVpn()->getData()->getResult();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants