Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are query images suppose to be in the database also? #48

Open
FrederikWarburg opened this issue Sep 18, 2019 · 1 comment
Open

Are query images suppose to be in the database also? #48

FrederikWarburg opened this issue Sep 18, 2019 · 1 comment
Labels
question Further information is requested

Comments

@FrederikWarburg
Copy link

Hi,
When I look at the test code for oxford5k, it seems that the query images are in the database also. When images for respectively the database and the query are found:

cfg = configdataset(dataset, os.path.join(get_data_root(), 'test'))
images = [cfg['im_fname'](cfg,i) for i in range(cfg['n'])]
qimages = [cfg['qim_fname'](cfg,i) for i in range(cfg['nq'])]

When I run

for im in qimages:
    if im in images:
        print(im)

it seems that all the images are also available in the database. As far as I understand, they are not suppose to be both places? It is probably me who am missing something, so a clarification on this would be appreciated. Thank you!

@filipradenovic
Copy link
Owner

Full size test images indeed are in the database, but at query time they are cropped before search, so the cropped versions are not exactly in the database. That is how the authors of the original Oxford Buildings dataset paper designed it.

Even so, we do recognize that this is a problem, so we proposed Revisited Oxford and Paris datasets (R-Oxford and R-Paris), in which query images are not part of the database. There are also additional improvements of the datasets, do read the paper for the details.

To use these revisited datasets in this toolbox, use 'roxford5k' and 'rparis6k'.

@filipradenovic filipradenovic added the question Further information is requested label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants