Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with hyphens in client name #249

Open
JohnSmall opened this issue Sep 30, 2024 · 0 comments
Open

Problems with hyphens in client name #249

JohnSmall opened this issue Sep 30, 2024 · 0 comments

Comments

@JohnSmall
Copy link

We have two clients, the main one, and a staging version. For development we want to use the staging client, but the staging client has a hyphen in the name .e.g OurCompanyName-staging.

When the filestack initialisation js runs on the page load, it tries to create a variable

//<![CDATA[ var OurCompanyName-staging = filestack.init('ourApiKey', {"cname":null}); //]]>

Which fails because Javascript doesn't allow hyphens in variable names.

Do we have to change the name of our staging client?

Can the code please handle this case better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant