Code Quality: Improved SetAs actions #16480
Open
+71
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Nov 18, 2024
src/Files.App/Actions/Content/Background/SetAsLockscreenBackgroundAction.cs
Outdated
Show resolved
Hide resolved
yaira2
reviewed
Nov 18, 2024
src/Files.App/Actions/Content/Background/SetAsSlideshowBackgroundAction.cs
Outdated
Show resolved
Hide resolved
yaira2
reviewed
Nov 18, 2024
src/Files.App/Actions/Content/Background/SetAsSlideshowBackgroundAction.cs
Outdated
Show resolved
Hide resolved
yaira2
reviewed
Nov 18, 2024
src/Files.App/Actions/Content/Background/SetAsWallpaperBackgroundAction.cs
Outdated
Show resolved
Hide resolved
yaira2
reviewed
Nov 18, 2024
yaira2
reviewed
Nov 19, 2024
|
|
||
| public override Task ExecuteAsync(object? parameter = null) | ||
| { | ||
| if (context.SelectedItem is not null) |
There was a problem hiding this comment.
@hishitetsu can you confirm if this is okay to remove? I'm pretty sure it's needed to prevent a crash.
There was a problem hiding this comment.
Yeah, this code is necessary because the item may be deselected between the time it is checked in IsExecutable and the time the action is actually executed.
There was a problem hiding this comment.
Why not use IsExecutable prop instead?
There was a problem hiding this comment.
Certainly, but I noticed we should do the following instead of simply checking to prevent NullReferenceException completely.
if (ContentPageContext.SelectedItem is ListedItem selectedItem)
AppearanceSettingsService.AppThemeBackgroundImageSource = selectedItem.ItemPath;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes