Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skeleton for nv25 to support development and testing #12686

Closed
rjan90 opened this issue Nov 10, 2024 · 7 comments · Fixed by #12707
Closed

Skeleton for nv25 to support development and testing #12686

rjan90 opened this issue Nov 10, 2024 · 7 comments · Fixed by #12707
Assignees
@kamuik16
Labels
good first issue Good for newcomers

Comments

@rjan90
Copy link
Contributor

rjan90 commented Nov 10, 2024 •
edited
Loading

Write the skeleton for nv25. This is part of a series of tickets across multiple repos, as building up a network upgrade skeleton requires changes across:

How to create a skeleton in Lotus is documented here: https://github.com/filecoin-project/lotus/blob/master/documentation/misc/Building_a_network_skeleton.md#lotus-checklist

Done Criteria

  • There is a network skeleton in Lotus, which bubbles up all the other dependencies, and allows one to run a 2k-network and see that it switches network version from nv24 --> nv25
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Nov 10, 2024
This was referenced Nov 10, 2024
Closed
Closed
Closed
@rjan90 rjan90 added the good first issue Good for newcomers label Nov 10, 2024
@kamuik16
Copy link
Contributor

would like to take up the issues across all repos again @rjan90 :)

@kamuik16
Copy link
Contributor

would you be able to assign me across all repos?

@rjan90
Copy link
Contributor Author

rjan90 commented Nov 14, 2024

Hey @kamuik16! I have already completed (or have code ready to go for the ref-fvm / go-state-types / filecoin-ffi changes. But feel free to pick up this Lotus issue :)

@kamuik16
Copy link
Contributor

Hey @kamuik16! I have already completed (or have code ready to go for the ref-fvm / go-state-types / filecoin-ffi changes. But feel free to pick up this Lotus issue :)

will take it up once rest of the issues are completed.

@BigLep BigLep moved this from 📌 Triage to 🐱 Todo in FilOz Nov 18, 2024
@BigLep
Copy link
Member

BigLep commented Nov 18, 2024

@kamuik16 : it looks like the other issues have been completed now if you're still planning to take this up. I have assigned the issue to you (but @rjan90 please step in if you have other thoughts/plans).

@kamuik16
Copy link
Contributor

@kamuik16 : it looks like the other issues have been completed now if you're still planning to take this up. I have assigned the issue to you (but @rjan90 please step in if you have other thoughts/plans).

Yep, I have started working on this, but it seems @rjan90 will have to do a release for go-state-types containing the nv25 skeleton.

@rjan90 rjan90 mentioned this issue Nov 19, 2024
Merged
@rjan90
Copy link
Contributor Author

rjan90 commented Nov 19, 2024

Yep, I have started working on this, but it seems @rjan90 will have to do a release for go-state-types containing the nv25 skeleton.

Opened the PR for the release here: filecoin-project/go-state-types#327. It will be published once I get a ✅ on it.

@kamuik16 kamuik16 mentioned this issue Nov 19, 2024
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from 🐱 Todo to 🎉 Done in FilOz Nov 25, 2024
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamuik16 kamuik16

Labels
good first issue Good for newcomers
Projects
FilOz
Status: ☑️ Done (Archive)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: nv25 network skeleton kamuik16/lotus
3 participants
@BigLep @rjan90 @kamuik16