-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Lotus Release v1.28.0 #12109
Comments
@aarshkshah1992 I have added some steps for pulling in all the needed dependencies for a network upgrade Lotus-version here: #12107 A couple of notes:
|
(expanding comment) Tracker of things that were done that weren't in the release issue template or other observations and lessons learned:
|
It's currently TBD whether this release will be cut from master or from releases (tracking 1.27.1). We will have to cherry pick some changes from master regardless, so it would be logistically simpler to cut the branch from master. @aarshkshah1992 is going to do due-diligence on 2024-06-25 looking at master...release/v1.27.1 to see if there's anything like events db migrations or anything else calling out for a mandatory release version. We’ll then update the text in issue description based on the decision. Note that until the release/v1.28.0 branch is cut, we should only merge changes relevant for nv23. (related #fil-lotus-dev thread) |
For anyone watching, we have confirmed we are still targeting RC1 for Thursday, 2024-06-27. |
fwiw i did a quick pass on master...jen/v1271prep and i think we can cut off base on master commit 7141847 + other nv23 must have PRs |
@aarshkshah1992 @jennijuju : I think we should use this github issue to track the code specifics for Lotus v1.28.0. As a result, I added tracking to the issue for things we're waiting on for RC1 and RC2. |
RC1 is now scheduled for 2024-07-01. Here is the relevant slack thread: https://filecoinproject.slack.com/archives/CP50PPW2X/p171952803942240 . (Issue description was updated too.) |
Re #12119 review comments addressed. |
For anyone watching this issue about the 1.28.0 final release, it will not be happening today (2024-07-23). It's expected to come 2024-07-24. The PR for the release is #12271, which lists the remaining work item (0.0.5 release of go-f3). |
I was unable to resolve conflicts, and failing test when trying to merge the I will go ahead and tag the |
For visibility, there have been active verbal discussions about how to handle the fact that the 1.28.0 tag is from the |
For context, my understanding is that the historical release process has been to tag from @rjan90 understandably ran into some issues when attempting to merge the release/v1.28.0 into the releases branch. As @rjan90 shared, this is in part due to some release automation that we wanted to try out with a real release (1.27.2 in this case). I think we have two paths forward:
Given we're a couple of weeks away from network upgrade, I don't think we should introduce more process changes, and I would vote to go with option 1 to maintain the status quo. Regardless of what path is taken, there is still the exercise of confirming that there are no changes in the releases branch that should make their way into
We couldn't find any instance of a commit that was in
(And yes, I'm sure there is a better "git fu" way of answering the questions of "are there any meaningful commits in branch X that aren't in branch Y - feedback/pointers welcome.) Diff comparing releases commits to releave/v1.28.0 commits using the `colordiff` command above
|
Per verbal, we are going to go with option 1 above. @rvagg is going to work on this PR. (I also updated the text to better clarify what is meant by "option 1"). |
Closing this now that https://github.com/filecoin-project/lotus/releases/tag/v1.28.1 has been published, and also the final step of merging releases branch back to master has been merged #12317 |
This takes release issue changes and observations from #12109 with also having an eye towards the upcoming release process changes per #12072 . The general goals here are: 1. Have a checkbox step for each step a releae engineer should take. 2. Reduce duplication in the template itself. Where content should be duplicated, there is a comment for the issue creator to handle the copy/pasting.
This takes release issue changes and observations from #12109 with also having an eye towards the upcoming release process changes per #12072 . The general goals here are: 1. Have a checkbox step for each step a releae engineer should take. 2. Reduce duplication in the template itself. Where content should be duplicated, there is a comment for the issue creator to handle the copy/pasting. * Removed experimental syntax testing. * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md Co-authored-by: Phi-rjan <[email protected]> * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md Co-authored-by: Phi-rjan <[email protected]> * Addressing feedback about version string update in master * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md Co-authored-by: Phi-rjan <[email protected]> * Clarifying with comments that backport step doesn't really apply to RC1. * Cleanup Changelog prep steps. Addded some commands for helping identify holes in changelog. --------- Co-authored-by: Phi-rjan <[email protected]>
…ect#12356) This takes release issue changes and observations from filecoin-project#12109 with also having an eye towards the upcoming release process changes per filecoin-project#12072 . The general goals here are: 1. Have a checkbox step for each step a releae engineer should take. 2. Reduce duplication in the template itself. Where content should be duplicated, there is a comment for the issue creator to handle the copy/pasting. * Removed experimental syntax testing. * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md Co-authored-by: Phi-rjan <[email protected]> * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md Co-authored-by: Phi-rjan <[email protected]> * Addressing feedback about version string update in master * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md Co-authored-by: Phi-rjan <[email protected]> * Clarifying with comments that backport step doesn't really apply to RC1. * Cleanup Changelog prep steps. Addded some commands for helping identify holes in changelog. --------- Co-authored-by: Phi-rjan <[email protected]>
This takes release issue changes and observations from #12109 with also having an eye towards the upcoming release process changes per #12072 . The general goals here are: 1. Have a checkbox step for each step a releae engineer should take. 2. Reduce duplication in the template itself. Where content should be duplicated, there is a comment for the issue creator to handle the copy/pasting. * Removed experimental syntax testing. * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md Co-authored-by: Phi-rjan <[email protected]> * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md Co-authored-by: Phi-rjan <[email protected]> * Addressing feedback about version string update in master * Update documentation/misc/RELEASE_ISSUE_TEMPLATE.md Co-authored-by: Phi-rjan <[email protected]> * Clarifying with comments that backport step doesn't really apply to RC1. * Cleanup Changelog prep steps. Addded some commands for helping identify holes in changelog. --------- Co-authored-by: Phi-rjan <[email protected]>
🚢 Estimated shipping date
RC1:
2024-06-27 (last confirmed 2024-06-24T18:44:46Z)RC2:
RC3:
RC4:
RC5:
v1.28.0 stable estimated:
2024-07-242024-07-23
Dependencies for releases
This is the set of changes that need to make it a given RC. This is effectively the set of changes to cherry-pick from master.
RC1
RC2 (current "calibration final-candidate")
This upgrade includes an additional migration to the events database. Node operators running Lotus with events turned on (off by default) may experience some delay in initial start-up as a minor database migration takes place. See [filecoin-project/lotus#12080](https://github.com/filecoin-project/lotus/pull/12080) for full details.
Mainnet Upgrade Release
✅ Release Checklist
release/v1.28.0
) from master.build/version.go
in themaster
branch tovX.Y.(Z+1)-dev
(bump from feature release) orvX.(Y+1).0-dev
(bump from mandatory release). Run make gen and make docsgen-cli before committing changeschore: bump version in master #12074
Prepping an RC
RC prep steps for network upgrade for Calibration
Update_Dependencies_Lotus.md
#12107RC1 Steps
build/version.go
needs to be updated to end with '-rcX' (in therelease/vX.Y.Z
branch)make gen && make docsgen-cli
vX.Y.Z-rcN
We've cut the first RC using these steps at https://github.com/filecoin-project/lotus/releases/tag/v1.28.0-rc1.
RC2 Steps
build/version.go
needs to be updated to end with '-rcX' (in therelease/vX.Y.Z
branch)make gen && make docsgen-cli
vX.Y.Z-rcN
Stable Release
version.go
has been updated.make gen && make docsgen-cli
)release-vX.Y.Z
into thereleases
branch.releases
branch) withvX.Y.Z
Post-Release
releases
branch back intomaster
, ignoring the changes toversion.go
(keep the-dev
version from master). Do NOT delete thereleases
branch when doing so!releases
andrelease/v1.28.0
are in master.The text was updated successfully, but these errors were encountered: