-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: v2 commp cid #5
base: master
Are you sure you want to change the base?
feat: v2 commp cid #5
Conversation
@aschmahmann what happened to this PR? Is there a PieceCidV2 Implementation anywhere in go? Asking cause we've been happily using PieceCIDv2 in JS land for a while but are writing code now in go and I can't seem to find any PieceCIDv2 support, even though it was accepted as FRC a while ago. cc: @rvagg @ribasushi |
@hannahhoward in short this was dropped on the floor due to nucleation-winter. The most pressing issue is that As far as go-support: for Afaik @magik6k is writing his own for Curio as well. |
A few additional points of context:
Certainly feel free to grab any code (whether operational or testing) from here in a future implementation, or ditch it entirely for someone else's. These branches are also able to be pushed to by the repo maintainers and they're free to do so if they'd like. To me the most important thing here is that people intending to have content identifiers that map uniquely to a single piece of content (i.e. all users of CIDs) actually have that capability so they don't accidentally end up with problems down the line. Glad you're getting use out of these and pushing things forward @hannahhoward. |
@aschmahmann perhaps just close this one...?
Feel free, I'd take extra tests for sure. |
hey it's a little nucleation drama, little fight over the multicodec table, and accepted FRC with an unmerged official PR due to one team's obstinance, and multiple alternate implementations -- this one is really just all the best typical PLN dramas rolled into one :) I love it. Ok well thanks for the guidance. I'm just gonna go see @magik6k implemented something in curio since that's who we're working directly with. We absolutely use this all over our JS code -- https://github.com/storacha/data-segment/blob/main/src/multihash.js#L26C1-L31C1 When I have more time I'll at least pickup the multicodec fight. |
Also cc: @alanshaw -- looks like we've got a bit of uncertainty on which piececid v2 to use over in go land. |
This is a PR for adding support for a new type of piece CID based on treating the piece like a single large block similar to Blake3 (another tree hash used in the IPFS ecosystem).
See the FRC for more details and discussion. This PR probably should not get merged until the FRC is merged.
Note: I switched to GitHub actions (copying the approach from https://github.com/protocol/.github) since my understanding was more projects are moving that way and I wanted to be able to test without relying on CircleCI, happy to remove this though. Can also register this project with https://github.com/protocol/.github for auto-updating of CI configs if that's desired.
cc @ribasushi @Kubuxu