Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor find_file from plotting-service to FIA-API including changing where DataViewer calls. #423

Open
Pasarus opened this issue Nov 22, 2024 · 0 comments · May be fixed by #424 or fiaisis/plotting-service#219
Open

Refactor find_file from plotting-service to FIA-API including changing where DataViewer calls. #423

Pasarus opened this issue Nov 22, 2024 · 0 comments · May be fixed by #424 or fiaisis/plotting-service#219
Assignees
@HumzahJavid

Comments

@Pasarus
Copy link
Member

Pasarus commented Nov 22, 2024 •
edited
Loading

It is actually 3 different endpoints starting from here:
https://github.com/fiaisis/plotting-service/blob/9c8fa1bd1afe775ab0bdb7d7dd8e1f96c54ccaef/plotting-service/plotting_service/plotting_api.py#L94

Each of the find_file endpoints needs to be refactored to the FIA-API, the DataViewer will also need the API it calls switched to the FIA-API for finding file paths.

Once we have the file_path, it will enable the /download work in #350 Frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HumzahJavid HumzahJavid

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Pasarus @HumzahJavid