-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip parameter #2
Comments
Actually, before i go back to actually re-implement this, do you have any numbers? Because i never had any maps that really warranted using skip, so this wasn't well tested and never actually benchmarked, iirc. So i guessed it's fair to cut this, less source of problems and confusion, etc etc. So in case you have a map that you could share that shows perf benefits in action, or even just some numbers with skip==1 and skip>1, that would be super helpful. (ok to use the older JPS for checking this). Alternatively, how big is your map? As you've been using skip you're probably aware of the problems it could cause; if all of your walls are thick enough to work with skip>1 without problems, maybe your map is too high-res and could do with less resolution? |
I was doing benchmark once. From my head, the time was divided by skip number, so: |
Hi, I'm excited to see that you created JPS v2 which is even faster than previous version. Actually I used the skip argument as my grid is very dense. Would like to have it back. Let me know if that's possibile.
The text was updated successfully, but these errors were encountered: