-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transient dependency on Guava 16 prohibits higher-level code moving to Guava 21 #12
Comments
Here's a 4-line patch that seems to do the trick. (One line of Java changed, and no other deprecation warnings found after updating to Guava 20.) |
Is this ever going to get merged? We're on Guava 23 now |
Have just created (my first ever) Pull Request. Hopefully this is trivial & risk-free enough to be picked up by the project maintainer. |
@huggsboson I notice that you've helped the community get some pull requests into I don't suppose you'd consider doing the same with this dependency of that project? (It's included via (Although I believe, without any Android experience myself, that it should be possible to upgrade them all to reference Guava 20 without breaking Android and Java 6 support.) |
The crash one sees when putting Guava 21 on the classpath is the following:
Guava 21 is appealing because it adds a number of very useful utilities for working with Java 8. However in this release, they have (after a period of planned deprecation) removed methods from their
Objects
class (due to Java 8 containing anObjects
class).I understand
jackson-coreutils
may wish to retain support for Java 6. Fortunately, Guava planned ahead and there is a window of cross-over:A solution may be for jackson-coreutils to depend on Guava 18, 19 or 20. These all contain the class
MoreObjects
as a duplicate ofObjects
from Guava 16. So it may just be a matter of bumping the Guava version and substitutingObjects
withMoreObjects
. Upstream code can then use Guava 21+ (which still contains these methods inMoreObjects
)An alternative might be to just inline the calls to the utility functions in
Objects
, if they are not used too frequently.Related:
The text was updated successfully, but these errors were encountered: