Improved feature-detection of chrome.sockets #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old version did not check if chrome.sockets.* actually exist. This caused problems with extensions built for Chromium-based browsers that tried to maintain the single codebase and do feature-detection at runtime. License: MIT Signed-off-by: Marcin Rataj <[email protected]>
Co-Authored-By: lidel <[email protected]>
jscissr
approved these changes
May 3, 2019
|
@jscissr any chance to publish a new release to npm with this? :) |
|
The problem is that @feross has enabled branch protection with required pull request review for master, and I can't approve my own changes. At the same time his status is:
I could publish to npm, but then I can't push the version update commit to GitHub. Some options I see are:
What do you think? |
|
You should be able to open a PR here: https://github.com/feross/chrome-net/compare/version-update?expand=1 |
Merged
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
May 13, 2019
Release includes feross/chrome-net#36 improved feature-detection of chrome.sockets
2 tasks
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Jun 2, 2019
Release includes feross/chrome-net#36 improved feature-detection of chrome.sockets
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Jun 2, 2019
switch to chrome-net v3.3.2 Release includes feross/chrome-net#36 (improved feature-detection of chrome.sockets) + usual dependency updates
|
Sorry that I missed this message. Were you able to get this issue figured out and a new version published to npm? |
|
Yes, its all good: it shipped in v3.3.2 |
|
I created a PR with the same fix for UDP API: feross/chrome-dgram#16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds explicit check if
chrome.sockets.tcpandchrome.sockets.tcpServerexist before registering related listeners.Why?
chrome-netdid not check if usedchrome.sockets.*APIs actually exist, which caused problems in browser extensions. Extension was unable to maintain the single codebase and do feature-detection at runtime (eg. Google Chrome withoutchrome.socketsvs Brave with).This PR makes it possible to include
chrome-netin generic build pipeline.Refs. ipfs/ipfs-companion#664 ipfs/ipfs-companion#716