From e84f829d3fbcfb8d06d5f6045971ef78680c13d5 Mon Sep 17 00:00:00 2001 From: Ondrej Dockal Date: Wed, 16 Oct 2024 09:33:02 +0200 Subject: [PATCH] fix(tests): not all update e2e tests were run (#9362) * fix(tests): add missing tag and make the update tests less complex Signed-off-by: Ondrej Dockal --- .github/workflows/e2e-main.yaml | 2 -- .github/workflows/pr-check.yaml | 2 -- .../src/specs/installation/update-install.spec.ts | 8 ++------ 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/e2e-main.yaml b/.github/workflows/e2e-main.yaml index 429cdf4efa4ea..0b273f29298e0 100644 --- a/.github/workflows/e2e-main.yaml +++ b/.github/workflows/e2e-main.yaml @@ -148,8 +148,6 @@ jobs: echo ("PODMAN_DESKTOP_BINARY=" + $path) >> $env:GITHUB_ENV - name: Run E2E Update test - env: - UPDATE_PODMAN_DESKTOP: true run: | echo "${{ env.PODMAN_DESKTOP_BINARY }}" pnpm test:e2e:update:run diff --git a/.github/workflows/pr-check.yaml b/.github/workflows/pr-check.yaml index 6462c2516bc5e..0027a3d416aa5 100644 --- a/.github/workflows/pr-check.yaml +++ b/.github/workflows/pr-check.yaml @@ -393,8 +393,6 @@ jobs: echo ("PODMAN_DESKTOP_BINARY=" + $path) >> $env:GITHUB_ENV - name: Run E2E Update test - env: - UPDATE_PODMAN_DESKTOP: true run: | echo "${{ env.PODMAN_DESKTOP_BINARY }}" pnpm test:e2e:update:run diff --git a/tests/playwright/src/specs/installation/update-install.spec.ts b/tests/playwright/src/specs/installation/update-install.spec.ts index 85bf5a593889b..39d006ea69afa 100644 --- a/tests/playwright/src/specs/installation/update-install.spec.ts +++ b/tests/playwright/src/specs/installation/update-install.spec.ts @@ -27,7 +27,6 @@ let sBar: StatusBar; let updateAvailableDialog: Locator; let updateDialog: Locator; let updateDownloadedDialog: Locator; -const performUpdate = process.env.UPDATE_PODMAN_DESKTOP ? process.env.UPDATE_PODMAN_DESKTOP : false; test.skip(isLinux, 'Update is not supported on Linux'); @@ -45,7 +44,7 @@ test.afterAll(async ({ runner }) => { }); test.describe - .serial('Podman Desktop Update Update installation offering @update-install', () => { + .serial('Podman Desktop Update installation @update-install', () => { test('Update is offered automatically on startup', async ({ welcomePage }) => { await playExpect(updateAvailableDialog).toBeVisible(); const updateNowButton = updateAvailableDialog.getByRole('button', { name: 'Update Now' }); @@ -70,10 +69,7 @@ test.describe await sBar.updateButtonTitle.click(); await handleConfirmationDialog(page, 'Update Available now', false, '', 'Cancel'); }); - }); -test.describe - .serial('Podman Desktop Update installation can be performed', () => { - test.skip(!performUpdate, 'Update test does not run as UPDATE_PODMAN_DESKTOP env. var. is not set'); + test('Update can be initiated', async () => { await sBar.updateButtonTitle.click(); await playExpect(updateAvailableDialog).toBeVisible();