Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FoundryVTT version to 11.309 #788

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Bump FoundryVTT version to 11.309 #788

merged 3 commits into from
Sep 28, 2023

Conversation

felddy
Copy link
Owner

@felddy felddy commented Sep 19, 2023

🗣 Description

Support version 11.309 of Foundry VTT.

Closes #792

See:

💭 Motivation and context

If I don't do it no one will.

🧪 Testing

Tested locally and in continuous integration.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Add a tag or create a release.

@DawidIzydor
Copy link
Contributor

When can we expect this PR to be merged? 11.309 was released almost a week ago and it contains an important security update

@felddy
Copy link
Owner Author

felddy commented Sep 25, 2023

There is currently an upstream issue with one of the Node image architectures that needs to be resolved before I can merge this PR. I am still trying to determine the root cause.

The webp security issue patched in 11.309 is part of Electron. Electron is not part of this container. As a work around you can set the FOUNDRY_VERSION environment variable to 11.309 with the current release of the image.

I appreciate your patience.

@af2005
Copy link

af2005 commented Sep 26, 2023

Thanks for your work! I see that the pipeline fails on the build for the linux/s390x platform. Have you considered dropping support for that ? IBM discontinued the servers running this architecture in 2004.

@felddy
Copy link
Owner Author

felddy commented Sep 26, 2023

Thanks for your work! I see that the pipeline fails on the build for the linux/s390x platform. Have you considered dropping support for that ? IBM discontinued the servers running this architecture in 2004.

I have not considered dropping support for the linux/s390x. I plan on supporting the same architectures as provided by the NodeJS base image.

IBM-Z mainframes are alive and well. The latest update to this product line was the z-16 in April 2023:

@felddy felddy force-pushed the release/11.309.0 branch 3 times, most recently from 6bfb2bb to 6408b91 Compare September 26, 2023 19:53
@felddy
Copy link
Owner Author

felddy commented Sep 28, 2023

Currently blocked by:

@felddy felddy mentioned this pull request Sep 28, 2023
1 task
@felddy felddy force-pushed the release/11.309.0 branch 2 times, most recently from 5676519 to 59e96f7 Compare September 28, 2023 21:53
@felddy
Copy link
Owner Author

felddy commented Sep 28, 2023

Now unblocked by:

@felddy felddy merged commit f2ac32d into develop Sep 28, 2023
37 checks passed
@felddy felddy deleted the release/11.309.0 branch September 28, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for foundry 11.309
3 participants