Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if the vcs-diff-lint crashes #36

Open
praiskup opened this issue Oct 3, 2024 · 0 comments
Open

Fail if the vcs-diff-lint crashes #36

praiskup opened this issue Oct 3, 2024 · 0 comments

Comments

@praiskup
Copy link
Member

praiskup commented Oct 3, 2024

I noticed in https://github.com/rpm-software-management/tito/actions/runs/11158295140/job/31014265915?pr=504 that the action reported "success" even though no lining has been done by pylint:

 Traceback (most recent call last):
  File "/usr/bin/vcs-diff-lint-csdiff-pylint", line 47, in <module>
    sys.exit(_main())
             ^^^^^^^
  File "/usr/bin/vcs-diff-lint-csdiff-pylint", line 23, in _main
    data = json.loads(pylint_result.stdout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

The problem was an unreadable pylintrc file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant