New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In pull-request, we should diff against ${{ github.event.pull_request.base.sha }} #18

Open

praiskup opened this issue May 24, 2023 · 0 comments

Member

praiskup commented May 24, 2023

Not against the (possibly updated) freshly checked-out origin/main branch.

This is the problem:

vcs-diff-lint-action/container/cmd

Line 69 in 0d6348a

git fetch origin "$target_branch:$target_branch" &>/dev/null

The generated diff might be unnecessarily big if a different pull-request was merged in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment