feat: initial implementation of walletv2 #6429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschisan
force-pushed
the
walletv2
branch
2 times, most recently
from
bf6127b
to
68aae67
Compare
joschisan
force-pushed
the
walletv2
branch
25 times, most recently
from
41ee984
to
2e36e7a
Compare
joschisan
force-pushed
the
walletv2
branch
3 times, most recently
from
6582968
to
994083a
Compare
douglaz
reviewed
Nov 25, 2024
| DustAmount, | ||
| #[error("Federation returned an error: {0}")] | ||
| FederationError(String), | ||
| #[error("The federation has no vetted gateways")] |
douglaz
reviewed
Nov 25, 2024
| FederationError(String), | ||
| #[error("The federation has no vetted gateways")] | ||
| NoConsensusFeerateAvailable, | ||
| #[error("The client does not have sufficicent funds to send the payment")] |
There was a problem hiding this comment.
Suggested change
| #[error("The client does not have sufficicent funds to send the payment")] | |
| #[error("The client does not have sufficient funds to send the payment")] |
douglaz
reviewed
Nov 25, 2024
| pub enum SendError { | ||
| #[error("Address is from a different network then the federation.")] | ||
| WrongNetwork, | ||
| #[error("The amount is to small to be send on-chain")] |
There was a problem hiding this comment.
Suggested change
| #[error("The amount is to small to be send on-chain")] | |
| #[error("The amount is too small to be sent on-chain")] |
douglaz
reviewed
Nov 25, 2024
| /// | ||
| /// # Errors | ||
| /// - This constructor returns an error if the relative fee is in excess of | ||
| /// one thousand parts per million. |
douglaz
reviewed
Nov 25, 2024
Comment on lines
+120
to
+121
| // change in feerate it stays invalid. Otherwise there exists a race condition | ||
| // where a client might consider a actually accepted transaction as rejected. |
There was a problem hiding this comment.
Suggested change
| // change in feerate it stays invalid. Otherwise there exists a race condition | |
| // where a client might consider a actually accepted transaction as rejected. | |
| // change in feerate, it remains invalid. Otherwise, there exists a race condition | |
| // where a client might consider an actually accepted transaction as rejected. |
douglaz
reviewed
Nov 25, 2024
| #[derive(Debug, Clone, Eq, PartialEq, Hash, Deserialize, Serialize, Encodable, Decodable)] | ||
| pub struct ReceiveFee { | ||
| // This index ensures that once a Fedimint transaction becomes invalid due to a | ||
| // change in feerate it stays invalid. Otherwise there exists a race condition |
douglaz
reviewed
Nov 25, 2024
| WrongOutputScript, | ||
| #[error("No up to date feerate is available at the moment. Please try again later.")] | ||
| NoConsensusFeerateAvailable, | ||
| #[error("The fee index is outdated. Please construct an new transaction.")] |
There was a problem hiding this comment.
Suggested change
| #[error("The fee index is outdated. Please construct an new transaction.")] | |
| #[error("The fee index is outdated. Please construct a new transaction.")] |
douglaz
reviewed
Nov 25, 2024
| NoConsensusFeerateAvailable, | ||
| #[error("The fee index is outdated. Please construct an new transaction.")] | ||
| IncorrectFeeRateIndex, | ||
| #[error("The total transaction fee is to low. Please construct an new transaction.")] |
There was a problem hiding this comment.
Suggested change
| #[error("The total transaction fee is to low. Please construct an new transaction.")] | |
| #[error("The total transaction fee is too low. Please construct a new transaction.")] |
douglaz
reviewed
Nov 25, 2024
| IncorrectFeeRateIndex, | ||
| #[error("The total transaction fee is to low. Please construct an new transaction.")] | ||
| InsufficientTotalFee, | ||
| #[error("Constructing the pegin transaction caused and arithmetic overflow")] |
There was a problem hiding this comment.
Suggested change
| #[error("Constructing the pegin transaction caused and arithmetic overflow")] | |
| #[error("Constructing the pegin transaction caused an arithmetic overflow")] |
douglaz
reviewed
Nov 25, 2024
| pub enum WalletOutputError { | ||
| #[error("The wallet output version is not supported by this federation")] | ||
| UnknownOutputVariant(#[from] UnknownWalletOutputVariantError), | ||
| #[error("Connected bitcoind is on wrong network.")] |
douglaz
reviewed
Nov 25, 2024
| NoFederationUTXO, | ||
| #[error("No up to date feerate is available at the moment. Please try again later.")] | ||
| NoConsensusFeerateAvailable, | ||
| #[error("The fee index is outdated. Please construct an new transaction.")] |
douglaz
reviewed
Nov 25, 2024
| NoConsensusFeerateAvailable, | ||
| #[error("The fee index is outdated. Please construct an new transaction.")] | ||
| IncorrectFeeRateIndex, | ||
| #[error("The total transaction fee is to low. Please construct an new transaction.")] |
douglaz
reviewed
Nov 25, 2024
| #[error("The fee index is outdated. Please construct an new transaction.")] | ||
| IncorrectFeeRateIndex, | ||
| #[error("The total transaction fee is to low. Please construct an new transaction.")] | ||
| InsufficicentTotalFee, |
There was a problem hiding this comment.
Suggested change
| InsufficicentTotalFee, | |
| InsufficientTotalFee, |
douglaz
reviewed
Nov 25, 2024
| IncorrectFeeRateIndex, | ||
| #[error("The total transaction fee is to low. Please construct an new transaction.")] | ||
| InsufficicentTotalFee, | ||
| #[error("Constructing the pegout transaction caused and arithmetic overflow")] |
douglaz
reviewed
Nov 25, 2024
| let outpoint = bitcoin::OutPoint { | ||
| txid: transaction.compute_txid(), | ||
| vout: u32::try_from(vout).expect( | ||
| "Bitcoin transaction has more then u32::MAX outputs", |
There was a problem hiding this comment.
Suggested change
| "Bitcoin transaction has more then u32::MAX outputs", | |
| "Bitcoin transaction has more than u32::MAX outputs", |
douglaz
reviewed
Nov 25, 2024
Comment on lines
+388
to
+390
| if Some(feerate) == dbtx.insert_entry(&FeeRateVoteKey(peer), &feerate).await { | ||
| bail!("Fee rate vote is redundant"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if Some(feerate) == dbtx.insert_entry(&FeeRateVoteKey(peer), &feerate).await { | |
| bail!("Fee rate vote is redundant"); | |
| } | |
| ensure!( | |
| Some(feerate) != dbtx.insert_entry(&FeeRateVoteKey(peer), &feerate).await, | |
| "Fee rate vote is redundant" | |
| ); |
douglaz
reviewed
Nov 25, 2024
| // Since the total number of transactions is bound the following addition | ||
| // and cast cannot overflow or truncate. | ||
|
|
||
| (unsigned_count + pending_count) as u32 |
There was a problem hiding this comment.
Suggested change
| (unsigned_count + pending_count) as u32 | |
| (unsigned_count + pending_count).try_into().expect("Since the total number of transactions is bound the addition cannot overflow or truncate") |
|
Concept NACK if the goal is to replace the "wallet v1" module. The primary issue here is that creating a single UTXO for the federation effectively and unavoidably turns the federation into a "mixer" by default. While a mixer might be an interesting project from a cypherpunk perspective, it poses significant risks for guardians and gateway operators, which could hinder its adoption by most real-world communities. Additionally, it may attract unwanted attention to the project and its developers. My main objection isn't to the existence of this module, but to it being the standard or default for fedimints. The standard module should have reasonable UTXO management suitable for all use cases. At a minimum, it should avoid unnecessary mixing of UTXOs. |
dpc
reviewed
Nov 25, 2024
| @@ -6,7 +6,7 @@ if grep -E "(fedimint-mint|fedimint-wallet|fedimint-ln)" fedimint-server/Cargo.t | |||
| >&2 echo "fedimint-server/Cargo.toml must not depend on modules" | |||
| return 1 | |||
| fi | |||
| if grep -E "(fedimint-mint|fedimint-wallet|fedimint-ln-(server|client))" fedimint-testing/Cargo.toml >&2 ; then | |||
| if grep -E "(fedimint-mint|fedimint-wallet-|fedimint-ln-(server|client))" fedimint-testing/Cargo.toml >&2 ; then | |||
There was a problem hiding this comment.
v2 module is also a module ... IIRC this rule is to prevent circular deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.