-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abstract-blob-store as a dependency #92
Comments
I am not a typescript expert but as far as I can see a dependence has been added in the types definition. However, from the JS code perspective this dependency is only used in tests (so as a dev dependency). @daffl probably knows how to fix this. |
I'd say that everything that is required in the production types file should be a production dependency. An alternative (since |
I agree, I am not a typescript fan but IMHO using it implies that we should depend on the interface so that if it is changed it will break at compilation time. |
Moving |
See #81. If
abstract-blob-store
is needed to compile the project,abstract-blob-store
should be a production dependency. It's currently a development dependency, so not installed when used in other projects.The text was updated successfully, but these errors were encountered: