Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFE footer incorrect margin #14

Closed
igobranco opened this issue Nov 28, 2024 · 1 comment · Fixed by #19
Closed

MFE footer incorrect margin #14

igobranco opened this issue Nov 28, 2024 · 1 comment · Fixed by #19
Assignees

Comments

@igobranco
Copy link
Member

igobranco commented Nov 28, 2024

Depending on the viewport size, sometimes it breaks.
Example:
Image

Ii think replacing the "container" to "container-xl" fixes the major problem of the incorrect margin.

<footer role="contentinfo">
    <section class="footer-navigation">
        <div class="container d-md-flex justify-content-between py-3">

To

<footer role="contentinfo">
    <section class="footer-navigation">
        <div class="container-xl d-md-flex justify-content-between py-3">

Nevertheless, even with container-xl it won't work fine on some viewports...
I think just showing on a single column for a wider viewport, it will fix the problem.
Image

@igobranco igobranco assigned igobranco and sandroscosta and unassigned igobranco Nov 28, 2024
@igobranco
Copy link
Member Author

Changed from container d-md-flex to container-xl d-xl-flex and fixed the problem!

@igobranco igobranco assigned igobranco and unassigned sandroscosta Dec 6, 2024
igobranco added a commit that referenced this issue Dec 6, 2024
The footer has too much elements that on tablet mode creates an
horizontal scroll.

fixes #14
igobranco added a commit that referenced this issue Dec 6, 2024
The footer has too much elements that on tablet mode creates an
horizontal scroll.

fixes #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants