Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for identifierBase #117

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

Jiralite
Copy link
Contributor

@Jiralite Jiralite commented Sep 20, 2023

cliff-jumper does the following to bump the version:

const newVersion = Semver.inc(currentClean, `${getReleaseType(options, releaseType)}`, options.preid ?? '');

There is another parameter called identifierBase. Most notably, setting this to false would remove the identifier base.

Examples:

inc("14.13.0", "preminor", "dev-1e5c14b74"); // 14.14.0-dev-1e5c14b74.0
inc("14.13.0", "preminor", "dev-1e5c14b74", "0"); // 14.14.0-dev-1e5c14b74.0
inc("14.13.0", "preminor", "dev-1e5c14b74", "1"); // 14.14.0-dev-1e5c14b74.1
inc("14.13.0", "preminor", "dev-1e5c14b74", false); // 14.14.0-dev-1e5c14b74

This pull request aims to utilise this parameter.

@Jiralite Jiralite changed the title feat: Add identifier base feat: Support identifier base Sep 20, 2023
@Jiralite Jiralite force-pushed the feat/identifier-base branch from e2a3dde to 421d7e0 Compare September 20, 2023 12:11
Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow I legit didn't know that existed. God bless because I hate the .0 stuff.

@favna favna force-pushed the feat/identifier-base branch from 421d7e0 to 7baaa9a Compare September 20, 2023 17:03
@favna favna changed the title feat: Support identifier base feat: add support for identifierBase Sep 20, 2023
@favna favna merged commit 37c919e into favware:main Sep 22, 2023
8 checks passed
@favna
Copy link
Member

favna commented Sep 22, 2023

Released in v2.2.0

@Jiralite Jiralite deleted the feat/identifier-base branch September 22, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants