-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] contenteditable="false" Inline Elements #472
Comments
MrAlexand0r
pushed a commit
to MrAlexand0r/solv-Squire
that referenced
this issue
Nov 29, 2024
MrAlexand0r
pushed a commit
to MrAlexand0r/solv-Squire
that referenced
this issue
Nov 29, 2024
…n AFTER contenteditable=false element instead of inside
MrAlexand0r
pushed a commit
to MrAlexand0r/solv-Squire
that referenced
this issue
Nov 29, 2024
…hey shouldn't, fixed compilation error caused by missing nullcheck
I don't have any immediate ideas, as this is not something we've needed to handle. I'd consider a PR if it didn't require extensive changes. |
I already created a pull request that fixes the most glaring issues with non editable inline elements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
I'm implementing placeholders in my application, but encountered minor issues using Squire:
firefox_DyL6rOmqVu.mp4
As seen in this video, when adding a character, in this example a whitespace , it's correctly added outside the contenteditable=false span. However, upon deleting it again, the cursor jumps inside the readonly span, causing unwanted behvaiour, like when pressing Enter, the element gets split up into two separate elements.
Regarding 1: There's existing logic for similar behavior with block elements, but not for inline elements.
Squire/source/keyboard/Backspace.ts
Lines 44 to 47 in cbd8881
I'm still looking for a solution to the second issue. Could you perhaps point me in the right direction?
If you're open to adding this feature to the editor, I can create a CodeSandbox and potentially even a Pull Request.
The text was updated successfully, but these errors were encountered: