Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to use the edition 2021 resolver whole the workspace #334

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

tetsuharuohzeki
Copy link
Contributor

This fixes the warning shown on running cargo build at first.

warning: virtual workspace defaulting to resolver = "1" despite one or more workspace members being on edition 2021 which implies resolver = "2"
note: to keep the current resolver, specify workspace.resolver = "1" in the workspace root's manifest
note: to use the edition 2021 resolver, specify workspace.resolver = "2" in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions

lib/Cargo.toml uses rust edition 2021 for a long time.

So I think resolver = "2" is nice to suppress this warning.

@pchickey pchickey merged commit 0923cf5 into fastly:main Nov 27, 2023
7 checks passed
@tetsuharuohzeki tetsuharuohzeki deleted the set-resolver-explicit branch November 28, 2023 05:28
cmckendry pushed a commit to 1stdibs/Viceroy that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants