Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config paths should be parameters #18

Open
osrl opened this issue Aug 27, 2018 · 5 comments
Open

Config paths should be parameters #18

osrl opened this issue Aug 27, 2018 · 5 comments

Comments

@osrl
Copy link

osrl commented Aug 27, 2018

I wanted to put config files to a different folder. I had to override CordovaScreenshots::CORDOVA_SCREENSHOTS_IOS_CONFIG_PATH from a lane as a workaround for now.

@janpio
Copy link
Collaborator

janpio commented Aug 27, 2018

Interesting - what's the use case behind that? Why not fastlane/cordova_screenshots/ios?

(For reference: https://github.com/ionic-zone/fastlane-plugin-cordova_screenshots/blob/master/lib/fastlane/plugin/cordova_screenshots/constants.rb)

@osrl
Copy link
Author

osrl commented Aug 27, 2018

I'm using different config files not related to cordova. I've put them to fastlane/config_files. I didn't want to create a different folder for cordova screenshots. That's not a priority though.

@janpio
Copy link
Collaborator

janpio commented Aug 27, 2018

Ok, that makes sense - having the folder structure to be configurable is a good thing. I don't like the folder structure fastlane dictates by itself as well.

You could just CordovaScreenshots::CORDOVA_SCREENSHOTS_IOS_CONFIG_PATH = 'fastlane/config_files' in your lane to achieve what you wanted?

@osrl
Copy link
Author

osrl commented Aug 27, 2018

Yes I've already done that for a workaround for now. Thanks 👍

@janpio
Copy link
Collaborator

janpio commented Aug 27, 2018

(I actually just wanted to confirm that I understood your initial message correctly and that this is possible ;) Confirmed :D )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants