Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with --partition alias #1

Open
shreyasgm opened this issue Dec 6, 2022 · 1 comment
Open

Does not work with --partition alias #1

shreyasgm opened this issue Dec 6, 2022 · 1 comment

Comments

@shreyasgm
Copy link

Thank you for this wonderful script. Just wanted to highlight a minor issue with this script.

The command find-best-partition -f run_jupyter.sh -o check:

Works when the header for run_jupyter.sh looks like this:

#!/bin/bash
#SBATCH -p test
...

But does not work when run_jupyter.sh starts like this:

#!/bin/bash
#SBATCH --partition=test
...

You would expect the code to run fine in both cases.

@mmshad
Copy link
Collaborator

mmshad commented Feb 9, 2023

Thank you @shreyasgm and sorry for checking the issue late. I'll fix this in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants