Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done:
{}
as literals in the shell.Why it matters:
How it was fixed:
Result:
PR-Codex overview
This PR focuses on improving the
hubble.sh
script to wait forGrafana
readiness and enhancing the event fetching logic inindex.ts
by using theURL
object for safe URL construction and adding error handling.Detailed summary
wait_for_grafana
function inscripts/hubble.sh
to checkGrafana
readiness.curl
command syntax for better readability.packages/hub-web/examples/events/index.ts
to use theURL
object.