Use cublasGemmGroupedBatchedEx
in cublas 12.5
#6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR is an attempt to use the
cublasGemmGroupedBatchedEx
api introduced in cublas 12.5 to calculate the grouped gemm. And the code has passedop_test.py
.There is an potential optimization that is not implemented yet. The origin
grouped_gemm
requires anbatch_sizes
variable on CPU. However, forcublasGemmGroupedBatchedEx
, theAarray
,Barray
andCarray
need to be located on device, which will move the CPU array back to GPU. And I think that we could allow thebatch_sizes
on GPU for this branch and calculate thed_Aarray
on torch withtensor.data_ptr()
andbatch_sizes
.Making everything on GPU would reduce the synchronization on all streams during training and potentially make the training faster. But it may require more changes on the current codebase. I wonder if you could share your preference on this? Thank you!
Also, it would be great if you could tell me the benchmark I need to compare this code with the origin branch :)