Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🕵️‍♂️ Add in Regex Parameter for Finding Testing Files #1

Open
3 tasks
William-McGonagle opened this issue Jan 1, 2022 · 4 comments
Open
3 tasks
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@William-McGonagle
Copy link
Member

Idea

We want this library to be as simple to use as possible, but also it needs to be modular and customizable. So, what we need now is the ability for users to configure the path for their testing files. And, this isn't going to be a static path but rather, they are going to specify a regex pattern and we will see if that pattern matches any of their files. If the pattern matches, we will test that file.

Todo

  • Add in a parameter to look for in the package.json so people can specify where they want to keep their test files
  • Allow them to put in regex as the parameter
  • Replace the current code with their regex when checking for the testing path
@William-McGonagle William-McGonagle added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 1, 2022
@William-McGonagle William-McGonagle moved this to Todo in FPA Website Jan 1, 2022
@William-McGonagle William-McGonagle changed the title Add in Regex Parameter for Finding Testing Files 🕵️‍♂️ Add in Regex Parameter for Finding Testing Files Jan 1, 2022
@Criticalcarpet
Copy link
Contributor

Hii @William-McGonagle ,

I am ready to work on this... I think the pattern checking should go inside in the index.js in test directory.
Could you please give some clear instructions for the working idea ?
Thank you.

@William-McGonagle
Copy link
Member Author

Hey @Criticalcarpet,

Sorry for the late reply. The idea of this whole thing is to just use the path.join() in node.js along with process.cwd(). You can then use this to read the directories for files and if they match certain parameters (like *.js for js files), then use those files.

Thanks,
William McGonagle

@Criticalcarpet
Copy link
Contributor

In which file may I implement this in the test directory ?
Shall I create a new file with the function ?

@William-McGonagle
Copy link
Member Author

@Criticalcarpet-

You can do it however you would like! I'm not super picky as the linter will soon fix formatting, so as long as the implementation works it should be good!

Thanks,
William McGonagle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Status: Todo
Development

No branches or pull requests

2 participants