Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOSS Review] Use declared constants #297

Open
abhishektiwari opened this issue Feb 6, 2024 · 2 comments
Open

[JOSS Review] Use declared constants #297

abhishektiwari opened this issue Feb 6, 2024 · 2 comments

Comments

@abhishektiwari
Copy link

abhishektiwari commented Feb 6, 2024 •
edited
Loading

Please use declared PENNSIEVE_URL everywhere else (e.g. 2 3 4). Duplicated constant PENNSIEVE_URL makes code untestable in local dev/integration test environment.

JOSS Review
@fairdataihub-bot fairdataihub-bot
Copy link

Hello! Thank you for opening this issue. Your input is valuable and helps improve the project. Can you please provide a detailed description of the problem you're encountering? Any additional information such as steps to reproduce the issue would be greatly appreciated. Thank you!

aaronm-2112 added a commit that referenced this issue Apr 25, 2024
@aaronm-2112
refactor: use declared PENNSIEVE_URL constant consistently #297
5918a12
@aaronm-2112
Copy link
Member

This particular issue has been addressed as per 5918a12.
However I will leave it open at the moment as there are some additional constants, particularly in curate.py, that need to be used similarly to the method in the above commit.

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhishektiwari @aaronm-2112