Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with prompt-toolkit 3.0.9 #51

Open
zblz opened this issue Jan 22, 2020 · 1 comment
Open

Does not work with prompt-toolkit 3.0.9 #51

zblz opened this issue Jan 22, 2020 · 1 comment
Assignees

Comments

@zblz
Copy link
Member

zblz commented Jan 22, 2020

Installing faculty-sync from scratch will pull prompt-toolkit 3.0.9, which leads to the following failure when trying to start faculty-sync:

Traceback (most recent call last):
  File "/Users/victor/.local/bin/faculty-sync", line 5, in <module>
    from faculty_sync import run
  File "/Users/victor/.local/pipx/venvs/faculty-sync/lib/python3.7/site-packages/faculty_sync/__init__.py", line 1, in <module>
    from .app import run  # noqa
  File "/Users/victor/.local/pipx/venvs/faculty-sync/lib/python3.7/site-packages/faculty_sync/app.py", line 8, in <module>
    from .ui import View
  File "/Users/victor/.local/pipx/venvs/faculty-sync/lib/python3.7/site-packages/faculty_sync/ui.py", line 11, in <module>
    from prompt_toolkit.eventloop import get_event_loop
ImportError: cannot import name 'get_event_loop' from 'prompt_toolkit.eventloop' (/Users/victor/.local/pipx/venvs/faculty-sync/lib/python3.7/site-packages/prompt_toolkit/eventloop/__init__.py)

Downgrading prompt-toolkit to 2.0.9 fixes it.

Might be worth reconsidering #14 for stability.

@zblz zblz assigned zblz and pbugnion and unassigned zblz Jan 22, 2020
@pbugnion
Copy link
Contributor

Thanks!

Somewhat fixed in #50 , which I'll release soon.
Deeper thinking about prompt toolkit 3 support would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants