-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and document using sml-sync on Windows #21
Comments
Do we have a machine running windows 10? |
Yes, in the engineering room. I believe the plan is also to get a Windows laptop. We can now reproducibly install One possible option to make installing more reliable would be to remove paramiko and just rely on rsync and ssh. |
We currently use paramiko for:
The only item here where latency is really important is 1. I think the right course of action is to try replacing 1. with shelling out to ssh and see if that materially impacts user experience. If it doesn't, we can press on and do all the others. |
I just validated changing step 1 to use I've played around with this while doing actual gmaps development and the extra time doesn't seem to affect the experience, so I think we should remove paramiko everywhere. Besides providing windows support, it will also make sml-sync handle network disconnections much more gracefully, since we wouldn't maintain a persistent connection between the laptop and the SherlockML server. |
Sounds good to me; seems like a good decision and that seems like reasonable sync times. Great idea! |
We should at least test sml-sync on the Linux subsystem in Windows to see if we can get something working.
Whatever the result, there should be some section in the README on Windows support.
The text was updated successfully, but these errors were encountered: