Failing to unregister hooks

[skierkowski]

Depending on external factors, the process may be killed before the "stop" block runs. The stop block unregisters the hook, so sometimes a hook may not be unregistered properly.

The hook_url is generated per instance, meaning it changes every time the process restarts. While the start block checks to see if the hook is already registered, this will always fail since the URL it searches for will always be different every time the block runs.

The solution would be pass the 'id' to the web_hook, so that it generates a URL like /v0.4/web_hooks/:id. The ID would have to be static across restarts, fixed to the user and room, and unique from any other user/room. As such it could be generated as a hash of the room name and api_key.

[skierkowski]

@andrewrdakers this might be a good one for you to fix. You'll have to work with the web_hooks to fix this issue which will teach you about listeners and web hooks in creating connectors.

[alismxwll]

I'll take a look, could you give me permissions so I can push to a branch. Thanks!