Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark todos logic #22

Open
shiryz opened this issue Jul 18, 2019 · 0 comments
Open

Mark todos logic #22

shiryz opened this issue Jul 18, 2019 · 0 comments

Comments

@shiryz
Copy link

shiryz commented Jul 18, 2019

The following lines in marktodos function can be more readable and shortened
https://github.com/facn6/week3_finalProject.io/blob/master/skeleton/logic.js#L56

if(item.done == true)
          {
            item.done = false;
          }
          else
          {
            item.done = true;

          }

What you're trying to do is change the state of the todo from true to false and vice versa and this can be done by returning the opposite state

item.done = !item.done;
return item;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant