Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularizing components #39

Open
bobbysebolao opened this issue Sep 5, 2019 · 0 comments
Open

Modularizing components #39

bobbysebolao opened this issue Sep 5, 2019 · 0 comments

Comments

@bobbysebolao
Copy link

There are some very small components (Image) and some very large ones (ImageUrl) in your app. Remember that a component should do one thing (i.e. does it make sense to have two separate components for 'avatarImage' and 'userName' when both share the same purpose of displaying the user's GitHub profile data?)

Check out this thread, as you can see there is no definitive answer, but you can bear these things in mind for future projects. I think most important is to adopt a consistent approach as a team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant