Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw CSS on development environment #85

Open
kelvien opened this issue Sep 26, 2019 · 0 comments
Open

Raw CSS on development environment #85

kelvien opened this issue Sep 26, 2019 · 0 comments

Comments

@kelvien
Copy link

kelvien commented Sep 26, 2019

I'm using webpack-flush-chunks version 2.0.3
I noticed these lines of code:

css: {
      toString: function toString() {
        return (
          // lazy-loaded in case not used
          DEV ? api.styles.toString() : '<style>' + stylesAsString(stylesheets, outputPath) + '</style>'
        );
      }
    }

Is there a particular reason why we are only showing raw CSS on non-DEV environment only? I just thought that it is better to return the raw CSS regardless of the environment. And use the exposed styles variable to get the linked stylesheets, the way it is now.
Doing this will make us see in dev as closely as possible with what we are going to see in production.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant