Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow type error #340

Open
pho3nixf1re opened this issue Jan 8, 2019 · 5 comments
Open

flow type error #340

pho3nixf1re opened this issue Jan 8, 2019 · 5 comments
Labels

Comments

@pho3nixf1re
Copy link

I'm getting this baffling error after upgrading from the Rudy branch to 2.1:

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/redux-first-router/dist/pure-utils/nestAction.js.flow:44:16

Missing type annotation for T. T is a type parameter declared in array type [1] and was implicitly instantiated at call
of method slice [2].

        41│     ? {
        42│       index: history.index,
        43│       length: history.entries.length,
 [1][2] 44│       entries: history.entries.slice(0) // history.entries.map(entry => entry.pathname)
        45│     }
        46│     : undefined)
        47│



Found 1 error

This seems to be a problem internal to the flow definition and I'm not sure how to resolve it. It cannot be ignored or cannot resolve module errors are thrown. Any ideas how this can be fixed on my end or is this something internal that must be fixed?

@ScriptedAlchemy
Copy link
Collaborator

Booo, yeah I’ll need to recheck the flow definitions. Could have been a PR that didn’t check flow types. I’ll take a look, but pretty much I must run flow internally and just add one line somewhere

@ScriptedAlchemy
Copy link
Collaborator

still need to check this out. will try to tomorrow

@edahlseng
Copy link

Just hit this one as well. @ScriptedAlchemy did you have any luck checking this out?

@ScriptedAlchemy
Copy link
Collaborator

Not yet, I’ve gone through some of it and for the time being just disabling the flow errors. There’s a few other things i need to address

@edahlseng
Copy link

Sounds good, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants