-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken insert
option
#264
Comments
@ScriptedAlchemy Is this fix out already? We are running into the same error on upgrade to v4.7.5... |
@khitrenovich I'd say yes, because its corresponding PR was merged. |
Okay, so I just did some deep dive into that. The PR was merged on May 30, while v4.7.5 (latest) was released on May 18 -
So apparently the fix is not released yet, and I've just opened #297 about it. |
Great, I hope it gets published soon, because it takes like a minute to be done with it. |
🎉 This issue has been resolved in version 4.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
While using the
insert
option, i get the following error when the application tries to insert a chunk in the browser:In fact, the user provided
insert
function is not injected into the bundle code.Culprit is this line (from #226): d41bafa#diff-1fdf421c05c1140f6d71444ea2b27638L385
The code responsible for injecting it has been forgotten in this PR.
In addition to this, this part of the feature isn't covered by #202 tests, but i imagine it's not really possible to test it in a more realistic fashion.
Culprit here: 6cd6510#diff-20c6b42869bc2385bcef4e1d9a7afa04R118-R124
The text was updated successfully, but these errors were encountered: